From aa07780dbbcaac37d0c55c1abb83059d01990ab2 Mon Sep 17 00:00:00 2001 From: Fu Hanxi Date: Fri, 25 Oct 2024 13:03:08 +0200 Subject: [PATCH] ci: disable sonarqube check --- .gitlab/ci/rules.yml | 9 ---- .gitlab/ci/static-code-analysis.yml | 82 ----------------------------- 2 files changed, 91 deletions(-) diff --git a/.gitlab/ci/rules.yml b/.gitlab/ci/rules.yml index 0ab3440f25..f6dd6a9737 100644 --- a/.gitlab/ci/rules.yml +++ b/.gitlab/ci/rules.yml @@ -430,15 +430,6 @@ - <<: *if-dev-push changes: *patterns-python-files -.rules:patterns:static-code-analysis-preview: - rules: - - <<: *if-dev-push - changes: *patterns-c-files - - <<: *if-dev-push - changes: *patterns-python-files - - <<: *if-dev-push - changes: *patterns-sonarqube-files - # !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! # DO NOT place comments or maintain any code from this line # diff --git a/.gitlab/ci/static-code-analysis.yml b/.gitlab/ci/static-code-analysis.yml index 55c64d3432..7c0abedde4 100644 --- a/.gitlab/ci/static-code-analysis.yml +++ b/.gitlab/ci/static-code-analysis.yml @@ -36,85 +36,3 @@ check_pylint: export files=$(find . -iname "*.py" -print); fi - pylint --rcfile=.pylintrc $files -r n --output-format=parseable > pylint-report.txt || exit 0 - -# build stage -# Sonarqube related jobs put here for this reason: -# Here we have two jobs. code_quality_check and code_quality_report. -# -# code_quality_check will analyze the code changes between your MR and -# code repo stored in sonarqube server. The analysis result is only shown in -# the comments under this MR and won't be transferred to the server. -# -# code_quality_report will analyze and transfer both of the newly added code -# and the analysis result to the server. -# -# Put in the front to ensure that the newly merged code can be stored in -# sonarqube server ASAP, in order to avoid reporting unrelated code issues -.sonar_scan_template: - stage: build - extends: .pre_check_template - image: - name: $SONARQUBE_SCANNER_IMAGE - before_script: - - source tools/ci/utils.sh - - export PYTHONPATH="$CI_PROJECT_DIR/tools:$CI_PROJECT_DIR/tools/ci/python_packages:$PYTHONPATH" - - fetch_submodules - # Exclude the submodules, all paths ends with /** - - submodules=$(get_all_submodules) - # get all exclude paths specified in tools/ci/sonar_exclude_list.txt | ignore lines start with # | xargs | replace all to - - custom_excludes=$(cat $CI_PROJECT_DIR/tools/ci/sonar_exclude_list.txt | grep -v '^#' | xargs | sed -e 's/ /,/g') - # Exclude the report dir as well - - export EXCLUSIONS="$custom_excludes,$submodules" - - export SONAR_SCANNER_OPTS="-Xmx2048m" - variables: - GIT_DEPTH: 0 - REPORT_PATTERN: clang_tidy_reports/*.txt - artifacts: - when: always - paths: - - $REPORT_PATTERN - expire_in: 1 week - dependencies: # Here is not a hard dependency relationship, could be skipped when only python files changed. so we do not use "needs" here. - - clang_tidy_check - - check_pylint - -code_quality_check: - extends: - - .sonar_scan_template - - .rules:patterns:static-code-analysis-preview - allow_failure: true # since now it's using exit code to indicate the code analysis result, - # we don't want to block ci when critical issues founded - script: - - export CI_MERGE_REQUEST_COMMITS=$(python ${CI_PROJECT_DIR}/tools/ci/ci_get_mr_info.py commits ${CI_COMMIT_REF_NAME} | tr '\n' ',') - # test if this branch have merge request, if not, exit 0 - - test -n "$CI_MERGE_REQUEST_IID" || exit 0 - - test -n "$CI_MERGE_REQUEST_COMMITS" || exit 0 - - sonar-scanner - -Dsonar.analysis.mode=preview - -Dsonar.branch.name=$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME - -Dsonar.cxx.clangtidy.reportPath=$REPORT_PATTERN - -Dsonar.exclusions=$EXCLUSIONS - -Dsonar.gitlab.ci_merge_request_iid=$CI_MERGE_REQUEST_IID - -Dsonar.gitlab.commit_sha=$CI_MERGE_REQUEST_COMMITS - -Dsonar.gitlab.merge_request_discussion=true - -Dsonar.gitlab.ref_name=$CI_MERGE_REQUEST_SOURCE_BRANCH_NAME - -Dsonar.host.url=$SONAR_HOST_URL - -Dsonar.login=$SONAR_LOGIN - -Dsonar.python.pylint.reportPath=pylint-report.txt - -code_quality_report: - extends: - - .sonar_scan_template - - .rules:protected - allow_failure: true # since now it's using exit code to indicate the code analysis result, - # we don't want to block ci when critical issues founded - script: - - sonar-scanner - -Dsonar.branch.name=$CI_COMMIT_REF_NAME - -Dsonar.cxx.clangtidy.reportPath=$REPORT_PATTERN - -Dsonar.exclusions=$EXCLUSIONS - -Dsonar.gitlab.commit_sha=$PIPELINE_COMMIT_SHA - -Dsonar.gitlab.ref_name=$CI_COMMIT_REF_NAME - -Dsonar.host.url=$SONAR_HOST_URL - -Dsonar.login=$SONAR_LOGIN - -Dsonar.python.pylint.reportPath=pylint-report.txt