From e7b3b75785a7d4fbc725fb6aae56989d199cd269 Mon Sep 17 00:00:00 2001 From: xutao Date: Tue, 17 Nov 2020 15:00:56 +0800 Subject: [PATCH] websocket_client : fix some issues for websocket client 1. will post twice disconnect event when read error 2. will block `timeout` times when set disable_auto_connect 3. When `esp_websocket_client_stop` before `esp_websocket_client_send*`, if the `esp_websocket_client_send*` fails, the status will change to 'WEBSOCKET_STATE_WAIT_TIMEOUT', and the next `esp_websocket_client_start` will fail forever --- .../esp_websocket_client/esp_websocket_client.c | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/components/esp_websocket_client/esp_websocket_client.c b/components/esp_websocket_client/esp_websocket_client.c index 4e74bff43b..f4196d0346 100644 --- a/components/esp_websocket_client/esp_websocket_client.c +++ b/components/esp_websocket_client/esp_websocket_client.c @@ -45,6 +45,12 @@ static const char *TAG = "WEBSOCKET_CLIENT"; action; \ } +#define ESP_WS_CLIENT_STATE_CHECK(TAG, a, action) if ((a->state) < WEBSOCKET_STATE_INIT) { \ + ESP_LOGE(TAG,"%s:%d (%s): %s", __FILE__, __LINE__, __FUNCTION__, "Websocket already stop"); \ + action; \ + } + + const static int STOPPED_BIT = BIT0; ESP_EVENT_DEFINE_BASE(WEBSOCKET_EVENTS); @@ -130,11 +136,15 @@ static esp_err_t esp_websocket_client_dispatch_event(esp_websocket_client_handle static esp_err_t esp_websocket_client_abort_connection(esp_websocket_client_handle_t client) { + ESP_WS_CLIENT_STATE_CHECK(TAG, client, return ESP_FAIL); esp_transport_close(client->transport); - client->wait_timeout_ms = WEBSOCKET_RECONNECT_TIMEOUT_MS; - client->reconnect_tick_ms = _tick_get_ms(); + + if (client->config->auto_reconnect) { + client->wait_timeout_ms = WEBSOCKET_RECONNECT_TIMEOUT_MS; + client->reconnect_tick_ms = _tick_get_ms(); + ESP_LOGI(TAG, "Reconnect after %d ms", client->wait_timeout_ms); + } client->state = WEBSOCKET_STATE_WAIT_TIMEOUT; - ESP_LOGI(TAG, "Reconnect after %d ms", client->wait_timeout_ms); esp_websocket_client_dispatch_event(client, WEBSOCKET_EVENT_DISCONNECTED, NULL, 0); return ESP_OK; } @@ -439,7 +449,6 @@ static esp_err_t esp_websocket_client_recv(esp_websocket_client_handle_t client) rlen = esp_transport_read(client->transport, client->rx_buffer, client->buffer_size, client->config->network_timeout_ms); if (rlen < 0) { ESP_LOGE(TAG, "Error read data"); - esp_websocket_client_abort_connection(client); return ESP_FAIL; } client->payload_len = esp_transport_ws_get_read_payload_len(client->transport);