Merge branch 'fix/tools_click_envvar_v5.0' into 'release/v5.0'

Tools: Improve idf.py error message when the argument value collides with the environment variable (v5.0)

See merge request espressif/esp-idf!21885
This commit is contained in:
Roland Dobai 2023-02-17 19:41:39 +08:00
commit ca16d12b22

View File

@ -527,9 +527,14 @@ def init_cli(verbose_output: List=None) -> Any:
default = () if option.multiple else option.default default = () if option.multiple else option.default
if global_value != default and local_value != default and global_value != local_value: if global_value != default and local_value != default and global_value != local_value:
raise FatalError( if hasattr(option, 'envvar') and option.envvar and os.getenv(option.envvar) != default:
'Option "%s" provided for "%s" is already defined to a different value. ' msg = (f'This option cannot be set in command line if the {option.envvar} '
'This option can appear at most once in the command line.' % (key, task.name)) 'environment variable is set to a different value.')
else:
msg = 'This option can appear at most once in the command line.'
raise FatalError(f'Option "{key}" provided for "{task.name}" is already defined to '
f'a different value. {msg}')
if local_value != default: if local_value != default:
global_args[key] = local_value global_args[key] = local_value