From e52e75f2deec752a1d8b2fcac0b83163c07fdbc6 Mon Sep 17 00:00:00 2001 From: Marius Vikhammer Date: Wed, 27 Jan 2021 11:24:27 +0800 Subject: [PATCH] spi_flash: disable mmap into instr space unit test for C3 On C3 the cache is programmatically split between Icache and dcache and with the default setup we dont leave a lot pages available for additional mmaps into instruction space. Disabling this test for now since any hypothetical use case for this is no longer supported "out of the box" --- components/spi_flash/test/test_mmap.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/components/spi_flash/test/test_mmap.c b/components/spi_flash/test/test_mmap.c index 047fe4328c..3cf0589145 100644 --- a/components/spi_flash/test/test_mmap.c +++ b/components/spi_flash/test/test_mmap.c @@ -153,8 +153,11 @@ TEST_CASE("Can mmap into data address space", "[spi_flash][mmap]") TEST_ASSERT_EQUAL_PTR(NULL, spi_flash_phys2cache(start, SPI_FLASH_MMAP_DATA)); } -#if !TEMPORARY_DISABLED_FOR_TARGETS(ESP32C3) -// TODO ESP32C3 IDF-2458 +#if !DISABLED_FOR_TARGETS(ESP32C3) +/* On C3 the cache is programmatically split between Icache and dcache and with the default setup we dont leave a lot pages + available for additional mmaps into instruction space. Disabling this test for now since any hypothetical use case for this + is no longer supported "out of the box" +*/ TEST_CASE("Can mmap into instruction address space", "[spi_flash][mmap]") {