blackbeard420/notcurses
1
0
Fork 0
mirror of https://github.com/dankamongmen/notcurses synced 2025-03-09 09:09:03 -04:00
Code Issues Projects Releases Wiki Activity

allow users to set the stdplane's resizecb

Browse Source 
Hardcode a call to ncplane_resize_maximize() in
notcurses_resize_internal() for the standard plane,
when handling the standard pile. allow the user
to set the standard plane's resize callback beyond
that. closes #2163.
This commit is contained in:
nick black 2021-09-13 01:23:24 -04:00 committed by nick black
parent 123c0d6307
commit 0213e026b2
3 changed files with 11 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
NEWS.md
View File

@ -1,7 +1,10 @@
This document attempts to list user-visible changes and any major internal
rearrangements of Notcurses.
* 2.4.1 (not yet released)
* 2.4.2 (not yet released)
* You can now set a resize callback on the standard plane.
* 2.4.1 (2021-09-12)
* `notcurses_check_pixel_support()` still returns 0 if there is no support
for bitmap graphics, but now returns an `ncpixelimple_e` to differentiate
the pixel backend otherwise. This result is strictly informative.

6
src/lib/notcurses.c
View File

@ -571,7 +571,6 @@ ncplane* ncplane_new_internal(notcurses* nc, ncplane* n,
// create an ncplane of the specified dimensions, but do not yet place it in
// the z-buffer. clear out all cells. this is for a wholly new context.
// FIXME set up using resizecb rather than special-purpose from SIGWINCH
static ncplane*
create_initial_ncplane(notcurses* nc, int dimy, int dimx){
ncplane_options nopts = {
@ -580,7 +579,7 @@ create_initial_ncplane(notcurses* nc, int dimy, int dimx){
.cols = dimx - (nc->margin_l + nc->margin_r),
.userptr = NULL,
.name = "std",
.resizecb = ncplane_resize_maximize,
.resizecb = NULL,
.flags = 0,
};
return nc->stdplane = ncplane_new_internal(nc, NULL, &nopts);
@ -2346,9 +2345,6 @@ ncplane* ncplane_boundlist(ncplane* n){
}
void ncplane_set_resizecb(ncplane* n, int(*resizecb)(ncplane*)){
if(n == notcurses_stdplane(ncplane_notcurses(n))){
return;
}
n->resizecb = resizecb;
}

6
src/lib/render.c
View File

@ -56,6 +56,12 @@ notcurses_resize_internal(ncplane* pp, int* restrict rows, int* restrict cols){
pile->dimx = *cols;
int ret = 0;
//notcurses_debug(n, stderr);
// if this pile contains the standard plane, it ought be resized to match
// the viewing area before invoking any other resize callbacks.
if(ncplane_pile(notcurses_stdplane(n)) == pile){
ncplane_resize_maximize(notcurses_stdplane(n));
}
// now, begin a resize callback cascade on the root planes of the pile.
for(ncplane* rootn = pile->roots ; rootn ; rootn = rootn->bnext){
if(rootn->resizecb){
ret |= rootn->resizecb(rootn);