blackbeard420/notcurses
1
0
Fork 0
mirror of https://github.com/dankamongmen/notcurses synced 2025-03-10 01:29:05 -04:00
Code Issues Projects Releases Wiki Activity

ncdirect: move down with raw-mode newlines

Browse Source 
The cud capability to move the cursor down doesn't
scroll (and shouldn't be used on the last row). We
have no reliable knowledge of whether we're on the
last row or not, so instead switch to raw mode, emit
the newlines, and switch back to whatever mode we
were in. This method is due to @dnkl aka Daniel Eklöf,
a gentleman and scholar who absolutely knows his shit.
Closes #1625.
This commit is contained in:
nick black 2021-05-05 04:49:02 -04:00
parent 96491e42df
commit 36a2d00fb3
No known key found for this signature in database
GPG Key ID: 5F43400C21CBFACC
1 changed files with 22 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
src/lib/direct.c
View File

@ -139,7 +139,10 @@ int ncdirect_cursor_right(ncdirect* nc, int num){
return term_emit(tiparm(nc->tcache.cuf, num), nc->ttyfp, false); return term_emit(tiparm(nc->tcache.cuf, num), nc->ttyfp, false);
} }
// if we're on the last line, we need some scrolling action. // if we're on the last line, we need some scrolling action. rather than
// merely using cud, we emit newlines in raw mode. this combination has
// the peculiar property of scrolling when necessary and not performing
// a carriage return -- a pure line feed.
int ncdirect_cursor_down(ncdirect* nc, int num){ int ncdirect_cursor_down(ncdirect* nc, int num){
if(num < 0){ if(num < 0){
@ -148,10 +151,26 @@ int ncdirect_cursor_down(ncdirect* nc, int num){
if(num == 0){ if(num == 0){
return 0; return 0;
} }
if(!nc->tcache.cud){ struct termios term, raw;
if(tcgetattr(nc->ctermfd, &term)){
return -1; return -1;
} }
return term_emit(tiparm(nc->tcache.cud, num), nc->ttyfp, false); memcpy(&raw, &term, sizeof(raw));
cfmakeraw(&raw);
if(tcsetattr(nc->ctermfd, TCSADRAIN, &raw)){
return -1;
}
int ret = 0;
while(num--){
if(ncfputc('\n', nc->ttyfp) == EOF){
ret = -1;
break;
}
}
if(tcsetattr(nc->ctermfd, TCSADRAIN, &term)){
return -1;
}
return ret;
} }
int ncdirect_clear(ncdirect* nc){ int ncdirect_clear(ncdirect* nc){