From 5009a25721252c5c9214db086c9359d4acce7c60 Mon Sep 17 00:00:00 2001 From: nick black Date: Tue, 6 Jul 2021 04:29:25 -0400 Subject: [PATCH] stop warning on truecolor but no ccc --- TERMINALS.md | 22 +++++++++++----------- src/lib/notcurses.c | 5 ----- 2 files changed, 11 insertions(+), 16 deletions(-) diff --git a/TERMINALS.md b/TERMINALS.md index 2f91c744d..c4ea721dd 100644 --- a/TERMINALS.md +++ b/TERMINALS.md @@ -63,17 +63,17 @@ relies on the font. Patches to correct/complete this table are very welcome! | Terminal | Pixel `TIOCGWINSZ` | `ccc` | Blocks | Recommended environment | Notes | | --------------- | ------------------ | ----- | ------ | ----------------------- | ----- | -| [Alacritty](https://github.com/alacritty/alacritty) | ✅ | ✅ |❌ |`TERM=alacritty` `COLORTERM=24bit` | [Sixel support WIP](https://github.com/ayosec/alacritty/tree/graphics) | -| [Contour](https://github.com/christianparpart/contour) | ❌ | ✅ |? |`TERM=contour-latest` ? | Claims Sixel support | +| [Alacritty](https://github.com/alacritty/alacritty) | ✅ | ✅ |❌ |`TERM=alacritty` `COLORTERM=24bit` | [Sixel support WIP](https://github.com/ayosec/alacritty/tree/graphics) | +| [Contour](https://github.com/christianparpart/contour) | ❌ | ✅ |? |`TERM=contour-latest` ? | Claims Sixel support | | [ETerm](https://github.com/mej/Eterm) | | | | `TERM=Eterm` | Doesn't reply to Send Device Attributes | -| [FBterm](https://github.com/zhangyuanwei/fbterm) | ❌ | ? |? |`TERM=fbterm` | 256 colors, no RGB color. | +| [FBterm](https://github.com/zhangyuanwei/fbterm) | ❌ | ? |? |`TERM=fbterm` | 256 colors, no RGB color. | | [foot](https://codeberg.org/dnkl/foot) | ✅ | ✅ |✅ |`TERM=foot` | Sixel support. | -| [Gnome Terminal](https://gitlab.gnome.org/GNOME/gnome-terminal) |❌ | ❌ |✅ |`TERM=gnome` `COLORTERM=24bit` | `ccc` support *is* available when run with `vte-256color`. | +| [Gnome Terminal](https://gitlab.gnome.org/GNOME/gnome-terminal) |❌ | ❌ |✅ |`TERM=gnome` `COLORTERM=24bit` | `ccc` support *is* available when run with `vte-256color`. | | [Guake](https://github.com/Guake/guake) | | ? |? | | | -| [ITerm2](https://github.com/gnachman/iTerm2) | | ? |? | | | -| [Kitty](https://github.com/kovidgoyal/kitty) | ✅ | ✅ |✅ |`TERM=xterm-kitty` | See below. | -| [kmscon](https://github.com/dvdhrm/kmscon) | | ? |? |`TERM=xterm-256color` | No RGB color AFAICT, nor any distinct terminfo entry. | -| [Konsole](https://invent.kde.org/utilities/konsole) | ❌ | ❌ |? |`TERM=konsole-direct` | | +| [ITerm2](https://github.com/gnachman/iTerm2) | | ? |? | | | +| [Kitty](https://github.com/kovidgoyal/kitty) | ✅ | ✅ |✅ |`TERM=xterm-kitty` | See below. | +| [kmscon](https://github.com/dvdhrm/kmscon) | | ? |? |`TERM=xterm-256color` | No RGB color AFAICT, nor any distinct terminfo entry. | +| [Konsole](https://invent.kde.org/utilities/konsole) | ❌ | ❌ |? |`TERM=konsole-direct` | | | Linux console | ❌ | ✅ |see [below](#the-linux-console) |`TERM=linux` `COLORTERM=24bit` | 8 (512 glyph fonts) or 16 (256 glyph fonts) colors max, but RGB values are downsampled to a 256-index palette. See below. | | mlterm | ✅ | ❌ |? |`TERM=mlterm-256color` | Do not set `COLORTERM`. `mlterm-direct` gives strange results. | | PuTTY | | ❌ |❌ |`TERM=putty-256color` `COLORTERM=24bit` | | @@ -83,9 +83,9 @@ relies on the font. Patches to correct/complete this table are very welcome! | st ("suckless") | ✅ | ✅ |? |`TERM=st-256color` `COLORTERM=24bit` | | | Terminator | ✅ | ? |? | ? | | | Terminology | ❌ | ❌ |? | `TERM=terminology` | | -| [Tilda](https://github.com/lanoxx/tilda) | | ? |? | ? | | -| [tmux](https://github.com/tmux/tmux/wiki) | | ❌ |n/a |`TERM=tmux-256color` `COLORTERM=24bit` | `tmux.conf` must apply `Tc`; see below. `bce` is available with the `tmux-256color-bce` definition. | -| [wezterm](https://github.com/wez/wezterm) | ✅ | ✅ |? |`TERM=wezterm` `COLORTERM=24bit` | See below. | +| [Tilda](https://github.com/lanoxx/tilda) | | ? |? | ? | | +| [tmux](https://github.com/tmux/tmux/wiki) | ✅ | ❌ |n/a |`TERM=tmux-256color` `COLORTERM=24bit`| `tmux.conf` must apply `Tc`; see below. `bce` is available with the `tmux-256color-bce` definition. | +| [wezterm](https://github.com/wez/wezterm) | ✅ | ✅ |? |`TERM=wezterm` `COLORTERM=24bit` | See below. | | [Windows Terminal](https://github.com/microsoft/terminal)| | ? |? | ? | | | [wterm](https://github.com/majestrate/wterm) | | ? |? | ? | | | [XFCE4 Terminal](https://gitlab.xfce.org/apps/xfce4-terminal) | ❌ | ✅ |✅ |`TERM=xfce` `COLORTERM=24bit` | No `xfce-direct` variant exists. | diff --git a/src/lib/notcurses.c b/src/lib/notcurses.c index 06a2ba27d..045768c34 100644 --- a/src/lib/notcurses.c +++ b/src/lib/notcurses.c @@ -866,11 +866,6 @@ init_banner_warnings(const notcurses* nc, FILE* out){ liness += 2; fprintf(out, " Warning! Colors subject to https://github.com/dankamongmen/notcurses/issues/4\n"); fprintf(out, " Specify a (correct) TrueColor TERM, or COLORTERM=24bit.\n"); - }else{ - if(!nc->tcache.caps.can_change_colors){ - liness += 1; - fprintf(out, " Warning! Advertised TrueColor but no 'ccc' flag\n"); - } } if(!notcurses_canutf8(nc)){ liness += 1;