blackbeard420/notcurses
1
0
Fork 0
mirror of https://github.com/dankamongmen/notcurses synced 2025-03-10 01:29:05 -04:00
Code Issues Projects Releases Wiki Activity

release-checklist: add scan-build invocation

Browse Source
This commit is contained in:
nick black 2020-05-07 00:53:23 -04:00
parent cbf46402f8
commit 67048bf5fa
No known key found for this signature in database
GPG Key ID: 5F43400C21CBFACC
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
doc/release-checklist.md
View File

@ -1,5 +1,6 @@
* clang-tidy check: * clang-tidy check with something like:
* `cmake "-DCMAKE_CXX_CLANG_TIDY=/usr/bin/clang-tidy-9;-checks=*" ..` * `cmake "-DCMAKE_CXX_CLANG_TIDY=/usr/bin/clang-tidy-11;-checks=-*,clang-analyzer-*,modernize-*,performance-*" ..`
* `scan-build cmake .. && scan-build make`
* Run tools/release.sh $OLDVERSION $VERSION * Run tools/release.sh $OLDVERSION $VERSION
* Finalize CHANGELOG.md * Finalize CHANGELOG.md
* Bumps version numbers everywhere they need bumping * Bumps version numbers everywhere they need bumping

2
src/lib/fd.c
View File

@ -317,7 +317,7 @@ int ncsubproc_destroy(ncsubproc* n){
int ret = 0; int ret = 0;
if(n){ if(n){
void* vret = NULL; void* vret = NULL;
ret = syscall(__NR_pidfd_send_signal, n->pidfd, SIGKILL, NULL, 0); syscall(__NR_pidfd_send_signal, n->pidfd, SIGKILL, NULL, 0);
// the thread waits on the subprocess via pidfd, and then exits. don't try // the thread waits on the subprocess via pidfd, and then exits. don't try
// to cancel the thread; rely on killing the subprocess. // to cancel the thread; rely on killing the subprocess.
pthread_join(n->nfp->tid, &vret); pthread_join(n->nfp->tid, &vret);