blackbeard420/weechat
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

core: enable background process under Cygwin to connect to servers, fix reconnection problem (bug #34626)

Browse Source 
The connection was not made with a fork() under Cygwin because the connect() in
child process was not working. This seems to be fixed in latest Cygwin, so this
hack has been removed and now a fork() is done for all systems.
This commit is contained in:
Sebastien Helleu 2011-10-23 12:07:30 +02:00
parent 60e88df4f2
commit 71bef80ce2
2 changed files with 4 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
ChangeLog
View File

@ -1,12 +1,15 @@
WeeChat ChangeLog
=================
Sébastien Helleu <flashcode@flashtux.org>
v0.3.7-dev, 2011-10-22
v0.3.7-dev, 2011-10-23
Version 0.3.7 (under dev!)
--------------------------
* core: enable background process under Cygwin to connect to servers, fix
reconnection problem (bug #34626)
Version 0.3.6 (2011-10-22)
--------------------------

12
src/core/wee-network.c
View File

@ -1030,9 +1030,7 @@ network_connect_with_fork (struct t_hook *hook_connect)
int rc;
const char *pos_error;
#endif
#ifndef __CYGWIN__
pid_t pid;
#endif
#ifdef HAVE_GNUTLS
/* initialize GnuTLS if SSL asked */
@ -1080,15 +1078,6 @@ network_connect_with_fork (struct t_hook *hook_connect)
HOOK_CONNECT(hook_connect, child_read) = child_pipe[0];
HOOK_CONNECT(hook_connect, child_write) = child_pipe[1];
#ifdef __CYGWIN__
/*
* connection may block under Cygwin, there's no other known way
* to do better today, since connect() in child process seems not to work
* any suggestion is welcome to improve that!
*/
network_connect_child (hook_connect);
network_connect_child_read_cb (hook_connect, 0);
#else
switch (pid = fork ())
{
/* fork failed */
@ -1115,5 +1104,4 @@ network_connect_with_fork (struct t_hook *hook_connect)
1, 0, 0,
&network_connect_child_read_cb,
hook_connect);
#endif
}