From 622bf2bdf79d78aac5b6d1bb3c242f193ec9a83c Mon Sep 17 00:00:00 2001 From: Sir Poggles Date: Tue, 12 Jun 2012 18:26:43 -0700 Subject: [PATCH] fgets(): refer to the buffer size (no literals) --- win/configure.cpp | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/win/configure.cpp b/win/configure.cpp index dc5eafc01..2310c7843 100644 --- a/win/configure.cpp +++ b/win/configure.cpp @@ -57,7 +57,7 @@ int get_int_option(const char * text, int def) static char buffer[500]; int ret; printf_c("%s\n[\033[1;32m%u\033[0m] -> ", text, def); - fgets(buffer, 500, stdin); + fgets(buffer, sizeof(buffer), stdin); if(sscanf(buffer, "%u", &ret) != 1) ret = def; @@ -70,7 +70,7 @@ bool get_bool_option(const char * text, bool def) static char buffer[500]; char ret[100]; printf_c("%s [\033[1;32m%c\033[0m] -> ", text, def ? 'y' : 'n'); - fgets(buffer, 500, stdin); + fgets(buffer, sizeof(buffer), stdin); if(sscanf(buffer, "%s", ret) != 1) strcpy(ret, def ? "y" : "n"); @@ -85,7 +85,7 @@ void get_string_option(const char * text, char * def, char * buf) printf_c("%s\n[\033[1;32m%s\033[0m] -> ", text, def); else printf_c("%s\n[] -> ", text); - fgets(buffer, 500, stdin); + fgets(buffer, sizeof(buffer), stdin); if(sscanf(buffer, "%s", buf) != 1) strcpy(buf, def); @@ -144,7 +144,7 @@ int get_svn_revision(char * buffer, size_t len) if (f) { for (int q = 0; q < 4; ++q) - fgets(buf, 1000, f); + fgets(buf, sizeof(buf), f); rev = atoi(buf); sprintf(buffer, "%u", rev); @@ -218,8 +218,8 @@ void Run() FILE * fI = fopen("..\\src\\version.sh", "r"); if(fI) { - fgets(version, 514, fI); - fgets(version, 514, fI); + fgets(version, sizeof(version), fI); + fgets(version, sizeof(version), fI); char * p2 = version; while(*p2 != '\"') ++p2;