From 98397935cb5eefc2d8ac07b1b58dc700dc2406eb Mon Sep 17 00:00:00 2001 From: Sadie Powell Date: Thu, 27 Feb 2025 22:47:27 +0000 Subject: [PATCH] Deprecate bitmask DNSBL records. We don't use these in any of our docs or example configs and almost everyone uses the record type. Using a bitmask is also a source of footguns because users don't really understand how bit masks actually work. --- src/modules/m_dnsbl.cpp | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/modules/m_dnsbl.cpp b/src/modules/m_dnsbl.cpp index 9821d3bc6..58f1eee23 100644 --- a/src/modules/m_dnsbl.cpp +++ b/src/modules/m_dnsbl.cpp @@ -139,13 +139,16 @@ public: { "zline", Action::ZLINE }, }); - const std::string typestr = tag->getString("type"); + const std::string typestr = tag->getString("type", "record", 1); if (insp::equalsci(typestr, "bitmask")) { type = Type::BITMASK; bitmask = tag->getNum("bitmask", 0); records = 0; + + ServerInstance->Logs.Normal(MODNAME, " tag at {} specifies a bitmask. This is deprecated and will be removed in the next major version of InspIRCd, consider migrating to records instead.", + tag->source.str()); } else if (insp::equalsci(typestr, "record")) {