Strlen bashing.

git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@3600 e03df62e-2008-0410-955e-edbf42e46eb7
This commit is contained in:
brain 2006-03-09 18:18:18 +00:00
parent 797c8ac769
commit 9fd6aff54f
3 changed files with 6 additions and 16 deletions

View File

@ -72,11 +72,6 @@ class ModuleAntiBottler : public Module
if (!(data) || !(*data))
return;
/*
* slight efficiency fix: strtok() just returns NULL if it has no more
* tokens to return. Plus strlen's here really could have been replaced
* with above pointer voodoo :-). --w00t
*/
strtok(data," ");
char *ident = strtok(NULL," ");
char *local = strtok(NULL," ");

View File

@ -122,16 +122,12 @@ bool do_helpop(char **parameters, int pcnt, userrec *src)
search++;
}
/* XXX - don't we have an strtolower()? if not, might pay to add one.. that works on char *, preferably.. */
strlcpy(lower, search, MAXBUF);
for (unsigned int t = 0; t < strlen(lower); t++)
lower[t] = tolower(lower[t]);
strlower(search);
for (int i = 1; output != ""; i++)
{
snprintf(a,MAXBUF,"line%d",i);
output = helpop->ReadValue(lower, a, 0);
output = helpop->ReadValue(search, a, 0);
if (output != "")
{
Srv->SendTo(NULL,src,"290 "+std::string(src->nick)+" :"+output);

View File

@ -71,11 +71,10 @@ class RFC1413 : public InspSocket
if (section)
{
while (*section == ' ') section++; // strip leading spaces
int t = strlen(section);
for (int j = 0; j < t; j++)
if ((section[j] < 33) || (section[j]>126))
section[j] = '\0'; // truncate at invalid chars
if (strlen(section))
for (char* j = section; *j; j++)
if ((*j < 33) || (*j > 126))
*j = '\0'; // truncate at invalid chars
if (*section)
{
strlcpy(u->ident,section,IDENTMAX);
Srv->Log(DEBUG,"IDENT SET: "+std::string(u->ident));