ouch/inspircd
2
0
Fork 0
mirror of https://github.com/inspircd/inspircd.git synced 2025-03-10 02:59:01 -04:00
Code Issues Packages Projects Releases Wiki Activity

Add <security:allowcoreunload>.

Browse Source 
When enabled (the default) this setting prevents the unloading of
core modules such as cmd_privmsg.
This commit is contained in:
Peter Powell 2013-04-07 17:02:37 +01:00
parent 1626437cbf
commit b331d0549b
3 changed files with 18 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
docs/conf/inspircd.conf.example
View File

@ -657,6 +657,9 @@
# # # #
<security <security
# allowcoreunload: If this value is set to yes, Opers will be able to
# unload core modules (e.g. cmd_privmsg.so).
allowcoreunload="no"
# announceinvites: This option controls which members of the channel # announceinvites: This option controls which members of the channel
# receive an announcement when someone is INVITEd. Available values: # receive an announcement when someone is INVITEd. Available values:

9
src/commands/cmd_unloadmodule.cpp
View File

@ -42,12 +42,19 @@ class CommandUnloadmodule : public Command
CmdResult CommandUnloadmodule::Handle (const std::vector<std::string>& parameters, User *user) CmdResult CommandUnloadmodule::Handle (const std::vector<std::string>& parameters, User *user)
{ {
if (!ServerInstance->Config->ConfValue("security")->getBool("allowcoreunload") &&
InspIRCd::Match(parameters[0], "cmd_*.so", ascii_case_insensitive_map))
{
user->WriteNumeric(972, "%s %s :You cannot unload core commands!", user->nick.c_str(), parameters[0].c_str());
return CMD_FAILURE;
}
if (parameters[0] == "cmd_unloadmodule.so" || parameters[0] == "cmd_loadmodule.so") if (parameters[0] == "cmd_unloadmodule.so" || parameters[0] == "cmd_loadmodule.so")
{ {
user->WriteNumeric(972, "%s %s :You cannot unload module loading commands!", user->nick.c_str(), parameters[0].c_str()); user->WriteNumeric(972, "%s %s :You cannot unload module loading commands!", user->nick.c_str(), parameters[0].c_str());
return CMD_FAILURE; return CMD_FAILURE;
} }
Module* m = ServerInstance->Modules->Find(parameters[0]); Module* m = ServerInstance->Modules->Find(parameters[0]);
if (m && ServerInstance->Modules->Unload(m)) if (m && ServerInstance->Modules->Unload(m))
{ {

7
src/modules/m_globalload.cpp
View File

@ -79,6 +79,13 @@ class CommandGunloadmodule : public Command
CmdResult Handle (const std::vector<std::string> &parameters, User *user) CmdResult Handle (const std::vector<std::string> &parameters, User *user)
{ {
if (!ServerInstance->Config->ConfValue("security")->getBool("allowcoreunload") &&
InspIRCd::Match(parameters[0], "cmd_*.so", ascii_case_insensitive_map))
{
user->WriteNumeric(972, "%s %s :You cannot unload core commands!", user->nick.c_str(), parameters[0].c_str());
return CMD_FAILURE;
}
std::string servername = parameters.size() > 1 ? parameters[1] : "*"; std::string servername = parameters.size() > 1 ? parameters[1] : "*";
if (InspIRCd::Match(ServerInstance->Config->ServerName.c_str(), servername)) if (InspIRCd::Match(ServerInstance->Config->ServerName.c_str(), servername))