ouch/inspircd
2
0
Fork 0
mirror of https://github.com/inspircd/inspircd.git synced 2025-03-10 02:59:01 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fix the default case in GetFirstVisibleChannel and document it.

Browse Source
This commit is contained in:
Sadie Powell 2022-10-13 08:17:33 +01:00
parent e8e99c6ee7
commit d97a8f15de
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/coremods/core_who.cpp
View File

@ -180,8 +180,11 @@ class CommandWho : public SplitCommand
if (res == MOD_RES_DENY)
continue; // Module explicitly rejected this chan.
// A module didn't specify either way so use the default behaviour.
if (source == user || !memb->chan->IsModeSet(secretmode) || !memb->chan->IsModeSet(privatemode) || memb->chan->HasUser(source))
// A module didn't specify either way so use the default behaviour:
// 1. The requesting user is getting a WHO response for themself.
// 2. The +s (secret) and +p (private) channel modes are not set.
// 3. The requesting user is a member of the channel.
if (source == user || (!memb->chan->IsModeSet(secretmode) && !memb->chan->IsModeSet(privatemode)) || memb->chan->HasUser(source))
return memb;
}
return NULL;