blackbeard420/esp-idf
1
0
Fork 0
mirror of https://github.com/espressif/esp-idf synced 2025-03-09 09:09:10 -04:00
Code Issues Projects Releases Wiki Activity

fix(usb/host): Fix disconnection error handling

Browse Source 
In a very rare case of having 2 or more events of type
DISCONNECTION/ERROR/OVERCURRENT in a short time,
the driver has not yet recovered from
the 1st error but already got a 2nd error.

Closes https://github.com/espressif/esp-idf/issues/13364
Closes https://github.com/espressif/esp-idf/issues/15290
This commit is contained in:
Tomas Rezucha 2025-02-20 16:05:27 +01:00
parent ae11fd5c92
commit e3b21fb932
1 changed files with 14 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
components/usb/hub.c
View File

@ -1,5 +1,5 @@
/*
* SPDX-FileCopyrightText: 2015-2022 Espressif Systems (Shanghai) CO LTD
* SPDX-FileCopyrightText: 2015-2025 Espressif Systems (Shanghai) CO LTD
*
* SPDX-License-Identifier: Apache-2.0
*/
@ -834,6 +834,11 @@ static void root_port_handle_events(hcd_port_handle_t root_port_hdl)
break;
case HUB_DRIVER_STATE_ROOT_ENUM:
// This occurred during enumeration. Therefore, we need to recover the failed enumeration
// Because we want to in this order:
// 1. Reset ENUM FSM
// 2. Recover the port
// We do not set action 'HUB_DRIVER_FLAG_ACTION_PORT_RECOVER' here,
// it will be set from enum_handle_events()->enum_stage_cleanup_failed()
p_hub_driver_obj->dynamic.flags.actions |= HUB_DRIVER_FLAG_ACTION_ENUM_EVENT;
p_hub_driver_obj->single_thread.enum_ctrl.stage = ENUM_STAGE_CLEANUP_FAILED;
break;
@ -841,6 +846,14 @@ static void root_port_handle_events(hcd_port_handle_t root_port_hdl)
// There was an enumerated device. We need to indicate to USBH that the device is gone
pass_event_to_usbh = true;
break;
case HUB_DRIVER_STATE_ROOT_RECOVERY:
// In a very rare case of having 2 or more events of type DISCONNECTION/ERROR/OVERCURRENT
// in a short time, we can endup here, where the driver has not yet recovered from
// the 1st error but already got a 2nd error.
// Just check that the RECOVER action is requested and return
assert(p_hub_driver_obj->dynamic.flags.actions | HUB_DRIVER_FLAG_ACTION_PORT_RECOVER);
break;
case HUB_DRIVER_STATE_INSTALLED:
default:
abort(); // Should never occur
break;