ouch/inspircd
2
0
Fork 0
mirror of https://github.com/inspircd/inspircd.git synced 2025-03-09 10:39:02 -04:00
Code Issues Packages Projects Releases Wiki Activity

Deprecate bitmask DNSBL records.

Browse Source 
We don't use these in any of our docs or example configs and almost
everyone uses the record type. Using a bitmask is also a source of
footguns because users don't really understand how bit masks
actually work.
This commit is contained in:
Sadie Powell 2025-02-27 22:47:27 +00:00
parent 72ff58f7ed
commit 98397935cb
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/modules/m_dnsbl.cpp
View File

@ -139,13 +139,16 @@ public:
{ "zline", Action::ZLINE }, { "zline", Action::ZLINE },
}); });
const std::string typestr = tag->getString("type"); const std::string typestr = tag->getString("type", "record", 1);
if (insp::equalsci(typestr, "bitmask")) if (insp::equalsci(typestr, "bitmask"))
{ {
type = Type::BITMASK; type = Type::BITMASK;
bitmask = tag->getNum<unsigned int>("bitmask", 0); bitmask = tag->getNum<unsigned int>("bitmask", 0);
records = 0; records = 0;
ServerInstance->Logs.Normal(MODNAME, "<dnsbl> tag at {} specifies a bitmask. This is deprecated and will be removed in the next major version of InspIRCd, consider migrating to records instead.",
tag->source.str());
} }
else if (insp::equalsci(typestr, "record")) else if (insp::equalsci(typestr, "record"))
{ {