7363 Commits

Author SHA1 Message Date
brain
6273e89901 Mention ulines too
git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@10617 e03df62e-2008-0410-955e-edbf42e46eb7
2008-10-02 23:14:45 +00:00
brain
d6bec26bc7 Comment on potentially confusing code
git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@10616 e03df62e-2008-0410-955e-edbf42e46eb7
2008-10-02 23:14:12 +00:00
brain
697098bb47 The module hook is kinda required.
git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@10615 e03df62e-2008-0410-955e-edbf42e46eb7
2008-10-02 22:30:37 +00:00
brain
a95616f608 Fix for bug #601
git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@10614 e03df62e-2008-0410-955e-edbf42e46eb7
2008-10-02 22:27:03 +00:00
brain
2a88309abe Some suggestions from jilles about handling unknown prefix errors, and some ideas of my own about handling unknown modes in client introduction to prevent leaving a desynched user on the source server
git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@10613 e03df62e-2008-0410-955e-edbf42e46eb7
2008-09-30 22:21:34 +00:00
w00t
8c470e0b44 Make topic optional for permanent channels tags.
git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@10610 e03df62e-2008-0410-955e-edbf42e46eb7
2008-09-29 11:16:07 +00:00
w00t
d28ea80026 Fix inverted logic in restrictchans that caused it to not play nice with permchannels.
git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@10609 e03df62e-2008-0410-955e-edbf42e46eb7
2008-09-29 10:07:46 +00:00
special
fee65af28e Replace the IP (in addition to hostname) for CGIIRC clients; fixes glines and zlines on IPs affecting cgiirc users. Thanks to Saz|Laptop
git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@10607 e03df62e-2008-0410-955e-edbf42e46eb7
2008-09-29 08:13:49 +00:00
brain
cbef292a6c I think this fixes the mode +k weirdness. Keys were never being set correctly in the channel data. gcc doesnt warn on cast from char* to bool.
git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@10606 e03df62e-2008-0410-955e-edbf42e46eb7
2008-09-29 01:40:17 +00:00
brain
f7a563946c Suggested by nenolod, lets add this for thread signal safety
git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@10605 e03df62e-2008-0410-955e-edbf42e46eb7
2008-09-28 11:56:57 +00:00
aquanight
546534d98e Fix <options:noservices> causing +o (and +q!) not being correctly given on channel create
git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@10604 e03df62e-2008-0410-955e-edbf42e46eb7
2008-09-26 18:16:14 +00:00
w00t
398e82a114 Initialise SSL session pointer to NULL to prevent a potentially unsafe comparison, thanks Macgyver.
git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@10602 e03df62e-2008-0410-955e-edbf42e46eb7
2008-09-26 10:50:53 +00:00
brain
224b040f43 Jersey cows!
git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@10600 e03df62e-2008-0410-955e-edbf42e46eb7
2008-09-25 20:33:05 +00:00
peavey
c1a107f780 Also fix here; glob patterns may not start with > or <. TODO: iterate comma sep tokenlist to catch LIST >0,<10000 as other IRCDs do.
git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@10599 e03df62e-2008-0410-955e-edbf42e46eb7
2008-09-25 12:41:39 +00:00
peavey
6d951971f2 Fix faulty logic, glob patterns may not start with > or <. TODO: iterate comma sep tokenlist to catch LIST >0,<10000 as other IRCDs do.
git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@10598 e03df62e-2008-0410-955e-edbf42e46eb7
2008-09-25 12:33:49 +00:00
brain
0bee078104 Fix for bug #610 reported by ankit, numeric changed to 505
git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@10596 e03df62e-2008-0410-955e-edbf42e46eb7
2008-09-24 19:02:15 +00:00
peavey
9526135e33 Fix for listening sockets not clearing their timeout on connected. Reported by Sazpaimon.
git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@10594 e03df62e-2008-0410-955e-edbf42e46eb7
2008-09-24 15:31:35 +00:00
brain
86ac9c800f Set Id property on a bunch of modules which lack it, etc.
git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@10593 e03df62e-2008-0410-955e-edbf42e46eb7
2008-09-22 15:22:15 +00:00
brain
d8e63234c4 warning-free on windows
git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@10592 e03df62e-2008-0410-955e-edbf42e46eb7
2008-09-22 11:28:44 +00:00
brain
edef3ac92b Windows compile fixes for RLine
git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@10591 e03df62e-2008-0410-955e-edbf42e46eb7
2008-09-22 08:38:45 +00:00
brain
d29a4aea91 Second part of fix for bug #605, make adding and removal of lines not case sensitive
git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@10590 e03df62e-2008-0410-955e-edbf42e46eb7
2008-09-22 01:16:15 +00:00
brain
243d8c2907 Fix for bug #605 reported by MacGuyver, if a line is expired when we are adding another with the same hostmask, replace the existing line with the new one
git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@10589 e03df62e-2008-0410-955e-edbf42e46eb7
2008-09-22 01:11:23 +00:00
brain
f24230582e Fix /STATS output to show the regex module in use
git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@10588 e03df62e-2008-0410-955e-edbf42e46eb7
2008-09-21 20:37:24 +00:00
brain
002f31f1dd Fix leak, thanks aquanight
git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@10586 e03df62e-2008-0410-955e-edbf42e46eb7
2008-09-21 16:55:12 +00:00
brain
337818ce51 No longer needed
git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@10585 e03df62e-2008-0410-955e-edbf42e46eb7
2008-09-21 16:21:10 +00:00
brain
1b2dd8489c Fix re-creation of config filters
git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@10584 e03df62e-2008-0410-955e-edbf42e46eb7
2008-09-21 16:18:56 +00:00
brain
7ef7a13f3f Because m_filter reads definitions from the conf, unlike rline, when we see our engine via OnLoadModule we must do a partial rehash to get these lines from the conf and ensure theyre applied, because they would have failed to apply initially.
git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@10583 e03df62e-2008-0410-955e-edbf42e46eb7
2008-09-21 16:11:27 +00:00
brain
acfe8c58f6 Well, that was moronic of me
git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@10582 e03df62e-2008-0410-955e-edbf42e46eb7
2008-09-21 16:06:09 +00:00
brain
805830a135 someone forget an instance
git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@10581 e03df62e-2008-0410-955e-edbf42e46eb7
2008-09-21 16:01:48 +00:00
brain
bccf48aa75 This compiles but is NOT tested yet. Do not use unless you like pain.
git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@10580 e03df62e-2008-0410-955e-edbf42e46eb7
2008-09-21 15:52:45 +00:00
w00t
ad35241743 Be consistent. Use ServerInstance in all places instead of 'Instance' in half. This has bugged me forever :p. I think I got all of extra/ too..
git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@10579 e03df62e-2008-0410-955e-edbf42e46eb7
2008-09-21 12:56:03 +00:00
brain
1daa5273d7 Fixes. Dont try and catch exceptions within the RLine ctor, we dont always want crud outputting to snomask x in every situation. Its up to the caller
that creates the object as to what they want to do with the exception and if they want it shown.


git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@10578 e03df62e-2008-0410-955e-edbf42e46eb7
2008-09-21 12:24:25 +00:00
brain
be609949e3 Fix various rline bugs, implement /stats R, and fix the issue where you get no error. "Something will already have said why it fucked up" -- what
about when the rline fails due to missing provider?
Also fix the fact that we dont have a catch around the Generate() in addline, which would just make insp abort.


git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@10577 e03df62e-2008-0410-955e-edbf42e46eb7
2008-09-21 12:17:31 +00:00
brain
ce6764c87f Fix bug discovered by Ankit, m_rline loaded without regex provider causes segfault because of missing check for NULL when querying RegexProvider
interface


git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@10576 e03df62e-2008-0410-955e-edbf42e46eb7
2008-09-21 11:58:51 +00:00
brain
82fdc01e33 Fix the 'i/o error on connection (no error)' stuff, by displaying 'connected closed unexpectedly' when errno == 0.
Also trigger failover whenever a connection times out in the new authentication timeout code (the connection isnt
properly established so the failover should trigger)


git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@10575 e03df62e-2008-0410-955e-edbf42e46eb7
2008-09-21 10:55:18 +00:00
aquanight
4a455cfeea Make regex providers load correctly. Move m_rline to use the regex providers, and also move m_rline out of extras/. Document provider modules, <rline:engine> and particularly the uselessness of <rline engine="glob">.
git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@10573 e03df62e-2008-0410-955e-edbf42e46eb7
2008-09-21 01:51:29 +00:00
brain
cbb95cffac Fix crash
git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@10572 e03df62e-2008-0410-955e-edbf42e46eb7
2008-09-21 00:51:18 +00:00
aquanight
b3cbd1a153 Move m_regex.h and m_regex_glob.cpp to main modules directory, as these have no requirements.
git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@10571 e03df62e-2008-0410-955e-edbf42e46eb7
2008-09-20 23:01:53 +00:00
brain
df91e30723 Remove the old TODO comment
git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@10570 e03df62e-2008-0410-955e-edbf42e46eb7
2008-09-20 22:25:47 +00:00
brain
636a52312b Fix a rather nasty race condition revealed by my reading through the comments and enhancing them. Back when i did executeable includes, i placed a 'todo' in the code which said something along the lines of:
'we cant pass a User* into the config reader any more, because when the config reader thread finishes, that user may be gone and this will crash. Consider using an UID instead so that if the user vanishes, we can
detect this situation.' Of course, nobody ever did this, so i'm doing it now to ensure we dont come up against some particularly ugly race condition crashes!


git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@10569 e03df62e-2008-0410-955e-edbf42e46eb7
2008-09-20 21:46:56 +00:00
brain
703ca18c66 More comments, and remove some unused craq. Someone (that being me) once wrote a craqy imitation of std::bitset called dynamicbitmask which took up a large amount of hashcomp.{h,cpp} before i actually knew that std::bitset existed. NOTHING has ever used this class, so whack it as tidyup, knowing it wont
break anything :)


git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@10567 e03df62e-2008-0410-955e-edbf42e46eb7
2008-09-20 21:14:25 +00:00
brain
b8e537eba7 Roll back core matcher to the 1.1 design, which doesnt fail various unit tests
git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@10564 e03df62e-2008-0410-955e-edbf42e46eb7
2008-09-20 17:52:48 +00:00
brain
a2b94d7a8b Add test suite tests for wildcard function for failures discovered by Ankit
git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@10563 e03df62e-2008-0410-955e-edbf42e46eb7
2008-09-20 17:44:04 +00:00
w00t
1aea2798cc Fix my massacre of kqueue, filters may not be or'd.
git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@10561 e03df62e-2008-0410-955e-edbf42e46eb7
2008-09-19 18:39:26 +00:00
brain
14539c29d6 inbound sockets need a timeout, too. 30 secs should be pleanty
git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@10560 e03df62e-2008-0410-955e-edbf42e46eb7
2008-09-19 11:07:42 +00:00
w00t
a8a36c9935 Don't check E:Lines when enforcing Q:Lines on connected users. Thanks MacGyver.
git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@10559 e03df62e-2008-0410-955e-edbf42e46eb7
2008-09-19 09:34:03 +00:00
peavey
b7a20454ce Implement timeout on outgoing server connections as per our docs <link:timeout>
git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@10558 e03df62e-2008-0410-955e-edbf42e46eb7
2008-09-19 02:00:04 +00:00
peavey
e1a9c3a9bc Reinvert order of insert/erase into user hash_map to avoid a lil crash :)
git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@10557 e03df62e-2008-0410-955e-edbf42e46eb7
2008-09-18 23:37:58 +00:00
brain
29b959e8e5 Roll back tweak to the starttls spec requested by kvirc devs, sorry we cant do this as we have other client devs breathing down our throats that it broke their clients :(
git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@10549 e03df62e-2008-0410-955e-edbf42e46eb7
2008-09-17 18:53:19 +00:00
brain
48d214c9bd Shrink users properly on quit, and make cloaks for all existing users on load, for situations where the cloaking module is loaded after the ircd is booted. Thanks Ankit
git-svn-id: http://svn.inspircd.org/repository/trunk/inspircd@10546 e03df62e-2008-0410-955e-edbf42e46eb7
2008-09-16 17:32:32 +00:00